cmccabe commented on code in PR #14306:
URL: https://github.com/apache/kafka/pull/14306#discussion_r1316393751
##########
server-common/src/main/java/org/apache/kafka/server/common/MetadataVersion.java:
##########
@@ -320,6 +323,19 @@ public short registerBrokerRecordVersion() {
}
}
+ public short registerControllerRecordVersion() {
+ if (isAtLeast(MetadataVersion.IBP_3_6_IV2)) {
Review Comment:
Sorry, this was left over from when the feature was in `IBP_3_6_IV2`
previously. Fixed now.
##########
server-common/src/main/java/org/apache/kafka/server/common/MetadataVersion.java:
##########
@@ -320,6 +323,19 @@ public short registerBrokerRecordVersion() {
}
}
+ public short registerControllerRecordVersion() {
+ if (isAtLeast(MetadataVersion.IBP_3_6_IV2)) {
Review Comment:
Sorry, this was left over from when the feature was in `IBP_3_6_IV2`
previously. Fixed now to be `IBP_3_7_IV0`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
