divijvaidya commented on code in PR #14329:
URL: https://github.com/apache/kafka/pull/14329#discussion_r1315061717
##########
core/src/main/java/kafka/log/remote/RemoteLogManager.java:
##########
@@ -379,9 +379,9 @@ public void stopPartitions(Set<TopicPartition>
topicPartitions,
LOGGER.error("Error while stopping the partition: {}, delete:
{}", tpId.topicPartition(), delete, ex);
}
});
- remoteLogMetadataManager.onStopPartitions(topicIdPartitions);
if (delete) {
// NOTE: this#stopPartitions method is called when Replica state
changes to Offline and ReplicaDeletionStarted
+ remoteLogMetadataManager.onStopPartitions(topicIdPartitions);
Review Comment:
> Stop partition request will be called when a topic is deleted, partition
is moved to another replica and node is stopped.
The 4th case in future is going to be when TS is disabled dynamically for a
topic (KIP-950). In such a scenario, TBRLMM will probably still have a problem
if the disablement has a "retain=delete". We can solve it in scope for KIP-950
but heads-up that some changes in TBRLMM will be required.
> In the first 2 cases, the request will have delete flag set to true.
When replica is moving to another node, why would `deleteRemoteLog` be true?
Yes, the `deleteLocalLog` will be true but not `deleteRemoteLog`. Please help
me understand this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
