kamalcph commented on code in PR #14329:
URL: https://github.com/apache/kafka/pull/14329#discussion_r1315644355


##########
core/src/main/java/kafka/log/remote/RemoteLogManager.java:
##########
@@ -379,9 +379,9 @@ public void stopPartitions(Set<TopicPartition> 
topicPartitions,
                 LOGGER.error("Error while stopping the partition: {}, delete: 
{}", tpId.topicPartition(), delete, ex);
             }
         });
-        remoteLogMetadataManager.onStopPartitions(topicIdPartitions);
         if (delete) {
             // NOTE: this#stopPartitions method is called when Replica state 
changes to Offline and ReplicaDeletionStarted
+            remoteLogMetadataManager.onStopPartitions(topicIdPartitions);

Review Comment:
   Add the respective assertions in the test.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to