tylerbertrand opened a new pull request, #14344:
URL: https://github.com/apache/kafka/pull/14344
Resolves cache misses in `checkstyle` tasks due to absolute paths in
`configProperties`.
Sets `configDirectory` extension property, which is made available by the
`checkstyle` plugin as `${config_loc}` in the `checkstyle` xml files, as shown
in the Checkstyle Gradle docs
[here](https://docs.gradle.org/current/userguide/checkstyle_plugin.html#sec:checkstyle_built_in_variables).
The absolute paths set in `configProperties` are then replaced by relative
paths from `configDirectory`. Because the header and suppression config file
names are static and only referenced once, these were removed from
`configProperties` and the file names are given directly in `checkstyle.xml`
[Task input comparison showing input differences between builds causing
cache
miss](https://ge.solutions-team.gradle.com/c/udumk6sv5uwbw/an5e6pclyiblm/task-inputs?cacheability=cacheable,overlapping-outputs,validation-failure)
[Task input comparison with fix applied - no differences between
builds](https://ge.solutions-team.gradle.com/c/ojlblvuooowjo/rrubheuf5ex5g/task-inputs?cacheability=cacheable,overlapping-outputs,validation-failure)
### Tests
Manually verified suppressions are working as expected:
* [checkStyleMain FAILS when calling `System.exit()` in
`MessageGenerator.java` with that suppression
DISABLED](https://ge.solutions-team.gradle.com/s/34amuqemmyili/failure#1)
* [checkStyleMain PASSES when calling `System.exit()` in
`MessageGenerator.java` with that suppression
ENABLED](https://ge.solutions-team.gradle.com/s/s62zwn5gfsu54/failure)
Manually verified header check is working as expected:
* [checkStyleMain FAILS when java file is missing license
header](https://ge.solutions-team.gradle.com/s/rjjqrqrmam6oq/failure#1)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
