tylerbertrand commented on code in PR #14344:
URL: https://github.com/apache/kafka/pull/14344#discussion_r1324618554


##########
build.gradle:
##########
@@ -685,6 +685,7 @@ subprojects {
   }
 
   checkstyle {
+    configDirectory = rootProject.layout.projectDirectory.dir("checkstyle")
     configFile = new File(rootDir, "checkstyle/checkstyle.xml")

Review Comment:
   Good point. It turns out `${configDirectory}/checkstyle.xml` is [the default 
location](https://docs.gradle.org/current/dsl/org.gradle.api.plugins.quality.CheckstyleExtension.html#org.gradle.api.plugins.quality.CheckstyleExtension:configFile),
 so there is actually no need to specify `configFile` in this case. I pushed a 
commit to remove that line.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to