jolshan commented on code in PR #14314:
URL: https://github.com/apache/kafka/pull/14314#discussion_r1316414818
##########
clients/src/main/java/org/apache/kafka/clients/admin/internals/PartitionLeaderStrategy.java:
##########
@@ -72,6 +79,12 @@ private void handleTopicError(
) {
switch (topicError) {
case UNKNOWN_TOPIC_OR_PARTITION:
+ if (!tolerateUnknownTopics) {
Review Comment:
> the operation would be retried if any metadata error was reported for any
individual topic partition, even if an error was also reported for the entire
topic. With this change, the operation always fails if an error is reported for
the entire topic, even if an error is also reported for one or more individual
topic partitions.
This change only changes the behavior for unknown topic or partition errors
right? Leader/broker not available continue to be retriable, topic auth,
invalid topic, and other errors continue to fail the request?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
