C0urante commented on code in PR #14314:
URL: https://github.com/apache/kafka/pull/14314#discussion_r1318748685
##########
clients/src/test/java/org/apache/kafka/clients/admin/KafkaAdminClientTest.java:
##########
@@ -5634,16 +5637,31 @@ public void testListOffsetsMetadataNonRetriableErrors()
throws Exception {
final TopicPartition tp1 = new TopicPartition("foo", 0);
- try (AdminClientUnitTestEnv env = new AdminClientUnitTestEnv(cluster))
{
- env.kafkaClient().setNodeApiVersions(NodeApiVersions.create());
+ Map<MetadataResponse, Class<? extends Throwable>> responsesAndFailures
= new HashMap<>();
Review Comment:
Leave it cleaner than you found it!
Pushed a commit that adds parameterization; if you'd prefer, can revert and
publish as a follow-up PR after we merge this one.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
