hudeqi commented on code in PR #14243: URL: https://github.com/apache/kafka/pull/14243#discussion_r1324079681
########## storage/src/main/java/org/apache/kafka/storage/internals/log/RemoteIndexCache.java: ########## @@ -112,27 +115,54 @@ public class RemoteIndexCache implements Closeable { * * We use {@link Caffeine} cache instead of implementing a thread safe LRU cache on our own. */ - private final Cache<Uuid, Entry> internalCache; - private final RemoteStorageManager remoteStorageManager; - private final ShutdownableThread cleanerThread; + private Cache<Uuid, Entry> internalCache; public RemoteIndexCache(RemoteStorageManager remoteStorageManager, String logDir) throws IOException { Review Comment: I have added "Visible for testing", and it is only used in test. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org