[GitHub] [kafka] hudeqi commented on a diff in pull request #14243: KAFKA-14912:Add a dynamic config for remote index cache size

[via GitHub]

hudeqi commented on code in PR #14243:
URL: https://github.com/apache/kafka/pull/14243#discussion_r1324143711


##########
core/src/main/scala/kafka/server/KafkaServer.scala:
##########
@@ -129,7 +129,7 @@ class KafkaServer(
 
   var logDirFailureChannel: LogDirFailureChannel = _
   @volatile private var _logManager: LogManager = _
-  var remoteLogManagerOpt: Option[RemoteLogManager] = None
+  @volatile var remoteLogManagerOpt: Option[RemoteLogManager] = None

Review Comment:
   updated.



##########
core/src/main/scala/kafka/server/KafkaBroker.scala:
##########
@@ -95,6 +95,7 @@ trait KafkaBroker extends Logging {
   def brokerTopicStats: BrokerTopicStats
   def credentialProvider: CredentialProvider
   def clientToControllerChannelManager: NodeToControllerChannelManager
+  def remoteLogManager: Option[RemoteLogManager]

Review Comment:
   updated.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org