bachmanity1 commented on code in PR #14410:
URL: https://github.com/apache/kafka/pull/14410#discussion_r1331617852
##########
streams/src/test/java/org/apache/kafka/streams/processor/internals/StreamsProducerTest.java:
##########
@@ -398,6 +395,8 @@ public void shouldNotSetTransactionIdIfEosDisabled() {
logContext,
mockTime
);
+
+
assertFalse(producerConfig.containsKey(ProducerConfig.TRANSACTIONAL_ID_CONFIG));
Review Comment:
as the name of this test suggests when EOS guarantee is disabled
StreamsProducer should not set transaction id. I thought that the previous
version of this test didn't make it obvious that the transaction id is really
not set, so instead of using a mock object as producer config, I'm using a real
object and explicitly checking for the existence of transaction id config. I've
done similar changes to the
`shouldSetTransactionIdUsingTaskIdIfEosAlphaEnabled` and
`shouldSetTransactionIdUsingProcessIdIfEosV2Enabled`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
