lianetm commented on code in PR #14364:
URL: https://github.com/apache/kafka/pull/14364#discussion_r1333624789
##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/AssignorSelection.java:
##########
@@ -79,6 +80,9 @@ public int hashCode() {
@Override
public String toString() {
- return String.format("Assignor selection {type:%s, name:%s}", type,
serverAssignor);
+ return "AssignorSelection(" +
+ "type=" + type +
+ ", serverAssignor='" + serverAssignor + '\'' +
Review Comment:
Agree with the pattern, I was only referring to having the nit of having
props aligned :
```
return "AssignorSelection(" +
"type=" + type + "," +
"serverAssignor='" + serverAssignor + '\''
...
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
