jlprat commented on PR #14434: URL: https://github.com/apache/kafka/pull/14434#issuecomment-1735603472
I think the problem is in the details, why this extra byte? Also, 1 extra byte might not be relevant, but at some point the overhead of extra bytes might cause performance regressions (overhead on network traffic + increased memory footprint). I did a bit of debugging on [`UnifiedLog.scala` line 826](https://github.com/apache/kafka/blob/3.6/core/src/main/scala/kafka/log/UnifiedLog.scala#L826) and found out that all the `dups` are in theory written with the same Snappy codec but they seem to have the same size with the previous snappy version and the newer one. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
