divijvaidya commented on PR #14434: URL: https://github.com/apache/kafka/pull/14434#issuecomment-1735632838
At https://github.com/apache/kafka/blob/65efb981347d6f81fb2713cd27cdfdfa9d8781b9/core/src/test/scala/unit/kafka/log/LogCleanerParameterizedIntegrationTest.scala#L149 we assume that after compression, the snappy will add 5 additional bytes. But that is an assumption which is dependent on Snappy's internal implementation. For the purpose of this test, we can set a reasonable value like `largeMessageSet.sizeInBytes + 50` (to be future proof) and it should pass. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
