hachikuji commented on code in PR #14444: URL: https://github.com/apache/kafka/pull/14444#discussion_r1349226317
########## clients/src/main/resources/common/message/ProduceResponse.json: ########## @@ -32,7 +32,9 @@ // records that cause the whole batch to be dropped. See KIP-467 for details. // // Version 9 enables flexible versions. - "validVersions": "0-9", + // + // Version 10 adds 'CurrentLeader' and 'NodeEndpoints' as tagged fields Review Comment: The tricky thing is that bumping the protocol version does not imply client support (the client can ignore tagged fields). But it does help for the standard client since we know the feature will be supported. That probably does make request analysis easier. So I guess I'm appeased. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
