jolshan commented on code in PR #14444:
URL: https://github.com/apache/kafka/pull/14444#discussion_r1350945079
##########
server-common/src/main/java/org/apache/kafka/server/common/MetadataVersion.java:
##########
@@ -338,7 +338,7 @@ public boolean isControllerRegistrationSupported() {
public short fetchRequestVersion() {
if (this.isAtLeast(IBP_3_5_IV1)) {
- return 15;
+ return 16;
Review Comment:
Hmm. Is this correct? In the upgrade scenario we will send request version
16 to brokers that may not have that version yet. I know we just ignore tagged
fields, but I'm not sure I recall if we can handle version bumps.
If this is always just the latest version, should it be hardcoded?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
