guozhangwang commented on code in PR #14549:
URL: https://github.com/apache/kafka/pull/14549#discussion_r1359654735
##########
streams/src/main/java/org/apache/kafka/streams/StreamsBuilder.java:
##########
@@ -87,12 +87,12 @@ public StreamsBuilder() {
*/
@SuppressWarnings("this-escape")
public StreamsBuilder(final TopologyConfig topologyConfigs) {
- topology = getNewTopology(topologyConfigs);
+ topology = newTopology(topologyConfigs);
internalTopologyBuilder = topology.internalTopologyBuilder;
internalStreamsBuilder = new
InternalStreamsBuilder(internalTopologyBuilder);
}
- protected Topology getNewTopology(final TopologyConfig topologyConfigs) {
Review Comment:
Have we double check that there's no callers outside KS code (like in other
repos) of this function? Just double checking.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
