mjsax commented on code in PR #14549:
URL: https://github.com/apache/kafka/pull/14549#discussion_r1360033529
##########
streams/src/main/java/org/apache/kafka/streams/StreamsBuilder.java:
##########
@@ -87,12 +87,12 @@ public StreamsBuilder() {
*/
@SuppressWarnings("this-escape")
public StreamsBuilder(final TopologyConfig topologyConfigs) {
- topology = getNewTopology(topologyConfigs);
+ topology = newTopology(topologyConfigs);
internalTopologyBuilder = topology.internalTopologyBuilder;
internalStreamsBuilder = new
InternalStreamsBuilder(internalTopologyBuilder);
}
- protected Topology getNewTopology(final TopologyConfig topologyConfigs) {
Review Comment:
This PR does not remove it, we just change the name, so code could break.
But yes, it's not public API so it should be ok. Going to merge. If there are
concerns raised later, we can always add a commit to revert before 3.7 release.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
