AndrewJSchofield commented on code in PR #14575:
URL: https://github.com/apache/kafka/pull/14575#discussion_r1364116550
##########
clients/src/main/java/org/apache/kafka/common/metrics/MetricsReporter.java:
##########
@@ -24,13 +24,14 @@
import org.apache.kafka.common.Reconfigurable;
import org.apache.kafka.common.annotation.InterfaceStability;
import org.apache.kafka.common.config.ConfigException;
+import org.apache.kafka.common.telemetry.ClientTelemetry;
/**
* A plugin interface to allow things to listen as new metrics are created so
they can be reported.
* <p>
* Implement {@link org.apache.kafka.common.ClusterResourceListener} to
receive cluster metadata once it's available. Please see the class
documentation for ClusterResourceListener for more information.
*/
-public interface MetricsReporter extends Reconfigurable, AutoCloseable {
+public interface MetricsReporter extends Reconfigurable, AutoCloseable,
ClientTelemetry {
Review Comment:
I think this is incorrect. MetricsReporter does not extend ClientTelemetry.
Actually, an instance of MetricsReporter might also implement ClientTelemetry.
With this scheme, every MetricsReporter would also implement ClientTelemetry.
##########
clients/src/main/java/org/apache/kafka/common/telemetry/ClientTelemetrySender.java:
##########
@@ -0,0 +1,71 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.kafka.common.telemetry;
+
+import org.apache.kafka.common.KafkaException;
+import org.apache.kafka.common.annotation.InterfaceStability;
+import org.apache.kafka.common.metrics.MetricsReporter;
+import org.apache.kafka.common.protocol.ApiKeys;
+import org.apache.kafka.common.requests.AbstractResponse;
+import org.apache.kafka.common.requests.AbstractRequest.Builder;
+
+import java.util.Optional;
+
+/**
+ * A {@link MetricsReporter} may implement this interface to indicate support
for sending client
+ * telemetry to the broker.
+ */
[email protected]
+public interface ClientTelemetrySender extends AutoCloseable {
Review Comment:
I don't think this was in the KIP. Maybe it should have been.
##########
clients/src/main/java/org/apache/kafka/common/telemetry/ClientTelemetry.java:
##########
@@ -0,0 +1,60 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.kafka.common.telemetry;
+
+import org.apache.kafka.common.metrics.MetricsContext;
+import org.apache.kafka.common.metrics.MetricsReporter;
+import org.apache.kafka.common.annotation.InterfaceStability;
+
+import java.util.Optional;
+
+/**
+ * A {@link MetricsReporter} may implement this interface to indicate support
for collecting client
+ * telemetry on the client or server side.
+ */
[email protected]
+public interface ClientTelemetry {
+
+ /**
+ * Implemented by the client {@link MetricsReporter} to provide a {@link
ClientTelemetrySender}
+ * instance.
+ * <p>
+ * This instance may be cached by the client.
+ *
+ * @return Optional client side instance of {@link ClientTelemetrySender}.
+ */
+ default Optional<ClientTelemetrySender> clientSender() {
Review Comment:
I'm not familiar with ClientTelemetrySender.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
