apoorvmittal10 commented on code in PR #14575: URL: https://github.com/apache/kafka/pull/14575#discussion_r1364653249
########## clients/src/main/java/org/apache/kafka/common/telemetry/ClientTelemetry.java: ########## @@ -0,0 +1,64 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.kafka.common.telemetry; + +import org.apache.kafka.common.metrics.MetricsContext; +import org.apache.kafka.common.metrics.MetricsReporter; +import org.apache.kafka.common.annotation.InterfaceStability; + +import java.util.Optional; + +/** + * A {@link MetricsReporter} may implement this interface to indicate support for collecting client Review Comment: Just repeating the same I mentioned on other comment. I was in an impression that we want Future MetricsReporter to support either client or server side mapping. And that's why this change existed in v1 of the code as well. Looking at it again seems I am creating fat interfaces and doesn't make much sense to create common ClientTelemetry interface with optional client and server behaviour rather split them. And let the implementation of MetricsReporter decide which client or server side additional provider it wants to support. I ll change it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
