cmccabe commented on code in PR #14545:
URL: https://github.com/apache/kafka/pull/14545#discussion_r1366008173
##########
clients/src/main/java/org/apache/kafka/common/requests/LeaderAndIsrRequest.java:
##########
@@ -42,26 +42,52 @@
public class LeaderAndIsrRequest extends AbstractControlRequest {
+ public enum Type {
+ None(0),
+ Incremental(1),
+ Full(2);
+
+ private final byte type;
+ Type(int type) {
+ this.type = (byte) type;
+ }
+
+ public byte asByte() {
Review Comment:
Usually we use toByte or toId
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
