cmccabe commented on code in PR #14545:
URL: https://github.com/apache/kafka/pull/14545#discussion_r1366011893
##########
core/src/main/scala/kafka/zk/migration/ZkTopicMigrationClient.scala:
##########
@@ -47,8 +47,14 @@ class ZkTopicMigrationClient(zkClient: KafkaZkClient)
extends TopicMigrationClie
if (!interests.contains(TopicVisitorInterest.TOPICS)) {
throw new IllegalArgumentException("Must specify at least TOPICS in
topic visitor interests.")
}
- val topics = zkClient.getAllTopicsInCluster()
- val replicaAssignmentAndTopicIds =
zkClient.getReplicaAssignmentAndTopicIdForTopics(topics)
+ val allTopics = zkClient.getAllTopicsInCluster()
+ val topicDeletions = readPendingTopicDeletions().asScala
+ val topicsToMigrated = allTopics -- topicDeletions
+ if (topicDeletions.nonEmpty) {
+ warn(s"Found ${topicDeletions.size} pending topic deletions:
$topicDeletions. These will be not migrated " +
Review Comment:
I think we should probably limit listing the topics that are being deleted
to like the first 10 or whatever. Otherwise we could generate quite a long
log4j message.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
