OmniaGM commented on code in PR #14516:
URL: https://github.com/apache/kafka/pull/14516#discussion_r1368798048


##########
core/src/main/scala/kafka/server/metadata/KRaftMetadataCache.scala:
##########
@@ -63,6 +63,7 @@ class KRaftMetadataCache(val brokerId: Int) extends 
MetadataCache with Logging w
                                        brokers: Array[Int],
                                        listenerName: ListenerName,
                                        filterUnavailableEndpoints: Boolean): 
java.util.List[Integer] = {
+    // TODO KAFKA-15362

Review Comment:
   Do we know what the perf impact on metadata requests is by adding the logic 
of KAFKA-15362 here? Especially with the warning comment in 
[L60](https://github.com/apache/kafka/blob/4612fe42af0df0a4c1affaf66c55d01eb6267ce3/core/src/main/scala/kafka/server/metadata/KRaftMetadataCache.scala#L60)
 regard adding extra logic to `KRaftMetadataCache.maybeFilterAliveReplicas`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to