OmniaGM commented on code in PR #14516:
URL: https://github.com/apache/kafka/pull/14516#discussion_r1368821203
##########
core/src/main/scala/kafka/zk/migration/ZkTopicMigrationClient.scala:
##########
@@ -102,7 +111,7 @@ class ZkTopicMigrationClient(zkClient: KafkaZkClient)
extends TopicMigrationClie
val assignments = partitions.asScala.map { case (partitionId, partition) =>
new TopicPartition(topicName, partitionId) ->
- ReplicaAssignment(partition.replicas, partition.addingReplicas,
partition.removingReplicas)
+ ReplicaAssignment(partition.replicaBrokerIds(),
partition.addingReplicas, partition.removingReplicas)
Review Comment:
scala nit: It is usually recommended to not use empty parentheses in scala
when a parameterless function has no side effect in both the definition of the
function and when they call it (which is the case for
`partition.replicaBrokerIds`).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
