chb2ab commented on code in PR #14627: URL: https://github.com/apache/kafka/pull/14627#discussion_r1373265206
########## clients/src/main/resources/common/message/FetchRequest.json: ########## @@ -53,7 +53,9 @@ // // Version 15 adds the ReplicaState which includes new field ReplicaEpoch and the ReplicaId. Also, // deprecate the old ReplicaId field and set its default value to -1. (KIP-903) - "validVersions": "0-15", + // + // Version 16 is the same as version 15. + "validVersions": "0-16", Review Comment: I'm not sure about this. The intention is for all the new fields to be optional, the client should be able to handle them not being populated (by doing a full metadata refresh), so it doesn't seem unstable to me. For reference FetchResponse already has the CurrentLeader field we're adding to ProduceResponse, we just never used it for anything. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
