jolshan commented on code in PR #14627:
URL: https://github.com/apache/kafka/pull/14627#discussion_r1373924152
##########
server-common/src/main/java/org/apache/kafka/server/common/MetadataVersion.java:
##########
@@ -360,7 +360,9 @@ public short partitionRecordVersion() {
}
public short fetchRequestVersion() {
- if (this.isAtLeast(IBP_3_5_IV1)) {
+ if (this.isAtLeast(IBP_3_7_IV0)) {
Review Comment:
I just realized that if we set the version as unstable, we may not be able
to use it here. 🤦♀️ Maybe we should remove the unstable version true if this
causes issues in tests.
Sorry for confusion.
##########
server-common/src/main/java/org/apache/kafka/server/common/MetadataVersion.java:
##########
@@ -360,7 +360,9 @@ public short partitionRecordVersion() {
}
public short fetchRequestVersion() {
- if (this.isAtLeast(IBP_3_5_IV1)) {
+ if (this.isAtLeast(IBP_3_7_IV0)) {
Review Comment:
I just realized that if we set the version as unstable, we may not be able
to use it here. 🤦♀️ Maybe we should remove the unstable version true if this
causes issues in tests.
Sorry for confusion.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
