ijuma commented on code in PR #14623: URL: https://github.com/apache/kafka/pull/14623#discussion_r1374596662
########## gradle/dependencies.gradle: ########## @@ -70,8 +70,9 @@ else // The default strategy (i.e. what `mockito-core` uses) changed to `inline` in 5.x because it works better with newer // Java versions. // We always use the `inline` strategy. +// For Scala 2.12 we have to use the mockito-inline library because otherwise we cannot return mocks of final classes. Review Comment: This comment is not accurate, `mockito-core` from version `5` does support that. The issue is that Scala 2.12 uses mockito 4. So, the additional check makes sense, but the comment doesn't. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
