clolov commented on code in PR #14623: URL: https://github.com/apache/kafka/pull/14623#discussion_r1374684030
########## gradle/dependencies.gradle: ########## @@ -70,8 +70,9 @@ else // The default strategy (i.e. what `mockito-core` uses) changed to `inline` in 5.x because it works better with newer // Java versions. // We always use the `inline` strategy. +// For Scala 2.12 we have to use the mockito-inline library because otherwise we cannot return mocks of final classes. Review Comment: Yes, you are absolutely correct. Unfortunately, even with the additional check I still cannot quite make all the tests to pass, so I will continue battling this. But thank you for the review! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
