Owen-CH-Leung commented on code in PR #14645:
URL: https://github.com/apache/kafka/pull/14645#discussion_r1376191766
##########
release.py:
##########
@@ -730,7 +730,7 @@ def select_gpg_key():
fail("Ok, giving up")
if not user_ok("Ok to push RC tag %s (y/n)?: " % rc_tag):
fail("Ok, giving up")
-cmd("Pushing RC tag", "git push %s %s" % (PUSH_REMOTE_NAME, rc_tag))
+cmd("Pushing RC tag", "git push %s %s" % (PUSH_REMOTE_NAME, rc_tag),
num_retries=0)
Review Comment:
Can I ask like when `git push` failed, do we expect the program to perform
clean up like the logic defined in the `def fail` ? Or the program can directly
exit with error ?
The current infinite loop lies in the fact that the API `def cmd` calls `def
fail` , which in return calls back `def cmd`, and hence the program never
exits. If we can exit directly with error upon failed `git push`, the
implementation can be a lot simplified.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
