divijvaidya commented on code in PR #14645:
URL: https://github.com/apache/kafka/pull/14645#discussion_r1377303863
##########
release.py:
##########
@@ -730,7 +730,7 @@ def select_gpg_key():
fail("Ok, giving up")
if not user_ok("Ok to push RC tag %s (y/n)?: " % rc_tag):
fail("Ok, giving up")
-cmd("Pushing RC tag", "git push %s %s" % (PUSH_REMOTE_NAME, rc_tag))
+cmd("Pushing RC tag", "git push %s %s" % (PUSH_REMOTE_NAME, rc_tag),
num_retries=0)
Review Comment:
Unfortunately, I don't have the logs now and it will take me time to
reproduce.
I agree with your assessment on the cmd/fail loop. Perhaps, we can detect
that the failure is due to git and in such cases, mark delete_gitrefs=false.
That will ensure that fail() does not call git commands again.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
