jolshan commented on code in PR #14387: URL: https://github.com/apache/kafka/pull/14387#discussion_r1379411500
########## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/metrics/CoordinatorMetricsShard.java: ########## @@ -0,0 +1,82 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.kafka.coordinator.group.metrics; + +import com.yammer.metrics.core.MetricName; +import org.apache.kafka.common.TopicPartition; + +/** + * A CoordinatorMetricsShard is mapped to a single CoordinatorShard. For gauges, each metrics shard increments/decrements + * based on the operations performed. Then, {@link CoordinatorMetrics} will perform aggregations across all shards. + * + * For sensors, each shard individually records the observed values. + */ +public interface CoordinatorMetricsShard { + /** + * Increment a gauge. + * + * @param metricName the metric name. + * @param isGlobal whether the metric is globally shared across shards + */ + void increment(MetricName metricName, boolean isGlobal); Review Comment: would it be more useful to have separate methods for global vs not global? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
