jolshan commented on code in PR #14387:
URL: https://github.com/apache/kafka/pull/14387#discussion_r1379424990
##########
checkstyle/import-control.xml:
##########
@@ -240,6 +240,7 @@
<allow pkg="org.apache.kafka.test" />
<allow pkg="org.apache.kafka.timeline" />
<subpackage name="metrics">
+ <allow pkg="com.yammer.metrics"/>
Review Comment:
Are we planning not to add any of the new sensor metrics though? I assume
that's what the description is referring to when it says we need to wait for
other things to get the sensors.
> Metrics to add after https://github.com/apache/kafka/pull/14408 is merged:
>offset deletions sensor (OffsetDeletions); Meter(offset-deletion-rate,
offset-deletion-count)
Metrics to add after https://issues.apache.org/jira/browse/KAFKA-14987 is
merged:
>offset expired sensor (OffsetExpired); Meter(offset-expiration-rate,
offset-expiration-count)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
