mjsax commented on code in PR #14626:
URL: https://github.com/apache/kafka/pull/14626#discussion_r1379511059
##########
streams/src/main/java/org/apache/kafka/streams/state/VersionedRecord.java:
##########
@@ -27,6 +27,7 @@
public final class VersionedRecord<V> {
private final V value;
private final long timestamp;
+ private final long validTo;
Review Comment:
Btw: given that `VersionedKeyQuery` also returns a `VersionedRecord`, I
believe we need to update it to set this timestamp correctly for historic
queried? If we query "latest" there is nothing to be done, but if we query an
older version based on an `asOfTimestamp` we might need to take care of this
case?
Might also be worth mentioning this on the KIP.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
