mjsax commented on PR #13909:
URL: https://github.com/apache/kafka/pull/13909#issuecomment-1790049927
Seems I missed you last comment -- sorry about this. The bot comment just
surfaced to me.
> May I ask how do we want to change the default value? I mean, if we are to
provide something custom instead of using the default value. What would be that
custom thingy?
Note, we only want a way to overwrite what we put into the docs, when
generating them. Right now we call `config(configName)` and it give us the
default value (which might depend on the machine we are running on).
For the html generation part, we want something like `html(configName)`
which would be something like:
```
if (htmlOverwrite(configName) != null) {
return htmlOverwrite(configName);
} else {
return config(configName);
}
```
For most configs not html overwrite existing, but for `state.dir` config we
would set it to somethin meaningful that makes sense in the docs, and we need
some code to actually add a optional html overwrite when we define a config:
```
CONFIG = new ConfigDef()
.define(STATE_DIR_CONFIG,
Type.STRING,
System.getProperty("java.io.tmpdir") + File.separator +
"kafka-streams",
"${java.io.tmpdir}", -- this is the new line to pass in
html overwrite
Importance.HIGH,
STATE_DIR_DOC)
```
Does this help?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
