Owen-CH-Leung commented on PR #13909: URL: https://github.com/apache/kafka/pull/13909#issuecomment-1792212097
> Thanks. Overall this looks very promising. > > Why do you want to change `build.gradle` though? I think it would be ok to just hard-code what we want to put into the HTML directly in the code. Why do we need an additional indirection via gradle? Thanks for your feedback! Yeah my original thought is that you guy would want to control the value of overridden string during grade build which will generate the doc. But hardcoding the string value to override also makes sense to me. I've adopted most of your suggestions. However I think it's still necessary to keep 2 constructors since all the fields of `ConfigKey` are supposed to be final and we can't change it to sth else once initialized (Unless we are ok to set the `alternativeString` as non-final). Let me know what you think. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
