junrao commented on code in PR #14621:
URL: https://github.com/apache/kafka/pull/14621#discussion_r1380427009
##########
clients/src/main/java/org/apache/kafka/clients/admin/ConfigEntry.java:
##########
@@ -222,6 +222,7 @@ public enum ConfigSource {
DYNAMIC_BROKER_LOGGER_CONFIG, // dynamic broker logger config that
is configured for a specific broker
DYNAMIC_BROKER_CONFIG, // dynamic broker config that is
configured for a specific broker
DYNAMIC_DEFAULT_BROKER_CONFIG, // dynamic broker config that is
configured as default for all brokers in the cluster
+ DYNAMIC_CLIENT_METRICS_CONFIG, // dynamic client metrics subscription
config that is configured for all clients
Review Comment:
@apoorvmittal10 : Thanks for the comment. I mis-understood the logic here.
The create/describe config RPC only applies to
topic/broker/BrokerLoggerConfigType and we are adding CLIENT_METRICS here.
quota/Ip level configs are handled by different types of PRC. So, the logic you
have here is fine.
##########
core/src/main/scala/kafka/server/KafkaServer.scala:
##########
@@ -543,7 +547,8 @@ class KafkaServer(
clusterId = clusterId,
time = time,
tokenManager = tokenManager,
- apiVersionManager = apiVersionManager)
+ apiVersionManager = apiVersionManager,
+ clientMetricsManager = clientMetricsManager)
Review Comment:
Since client metric is not supported in ZK mode, should we make
clientMetricsManager an Option and pass in None here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
