apoorvmittal10 commented on code in PR #14621:
URL: https://github.com/apache/kafka/pull/14621#discussion_r1379425234
##########
clients/src/main/java/org/apache/kafka/clients/admin/ConfigEntry.java:
##########
@@ -222,6 +222,7 @@ public enum ConfigSource {
DYNAMIC_BROKER_LOGGER_CONFIG, // dynamic broker logger config that
is configured for a specific broker
DYNAMIC_BROKER_CONFIG, // dynamic broker config that is
configured for a specific broker
DYNAMIC_DEFAULT_BROKER_CONFIG, // dynamic broker config that is
configured as default for all brokers in the cluster
+ DYNAMIC_CLIENT_METRICS_CONFIG, // dynamic client metrics subscription
config that is configured for all clients
Review Comment:
I might be wrong but shouldn't this be needed to make `kafka-config.sh` work
to create `subscription` for client_metrics. To support the `kafka-config.sh`
utility we would require change in `ConfigEntry` and `ConfigSource`. I have
this PR that uses same: https://github.com/apache/kafka/pull/14632
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
