agavra commented on code in PR #14659:
URL: https://github.com/apache/kafka/pull/14659#discussion_r1381969282
##########
streams/src/main/java/org/apache/kafka/streams/kstream/internals/KeyValueStoreMaterializer.java:
##########
@@ -27,26 +31,44 @@
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
+import java.util.HashSet;
+import java.util.Map;
+import java.util.Set;
+
/**
* Materializes a key-value store as either a {@link
TimestampedKeyValueStoreBuilder} or a
* {@link VersionedKeyValueStoreBuilder} depending on whether the store is
versioned or not.
*/
-public class KeyValueStoreMaterializer<K, V> {
+public class KeyValueStoreMaterializer<K, V> implements StoreFactory {
private static final Logger LOG =
LoggerFactory.getLogger(KeyValueStoreMaterializer.class);
private final MaterializedInternal<K, V, KeyValueStore<Bytes, byte[]>>
materialized;
+ private final Set<String> connectedProcessorNames = new HashSet<>();
+
+ private Materialized.StoreType defaultStoreType =
Materialized.StoreType.ROCKS_DB;
Review Comment:
yes, definitely a good call! I'll just extract a constant for it in
`StreamsConfig` and access it from there so we're not definign the default
twice.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
