ableegoldman commented on code in PR #14659:
URL: https://github.com/apache/kafka/pull/14659#discussion_r1382279047
##########
streams/src/main/java/org/apache/kafka/streams/kstream/Materialized.java:
##########
@@ -69,7 +70,21 @@ public class Materialized<K, V, S extends StateStore> {
// the built-in state store types
public enum StoreType {
ROCKS_DB,
- IN_MEMORY
+ IN_MEMORY;
+
+ public static StoreType parse(final String storeType) {
+ switch (storeType) {
+ case StreamsConfig.IN_MEMORY:
+ return StoreType.IN_MEMORY;
+ case StreamsConfig.ROCKS_DB:
+ default:
+ // for backwards compatibility, we ignore invalid store
Review Comment:
Honestly I would just make this change now, and throw an exception if it's
invalid. If you really want to keep the behavior the same for whatever reason,
that's fine too, but we should at least log a warning
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
