mdedetrich commented on PR #12728: URL: https://github.com/apache/kafka/pull/12728#issuecomment-1795695928
Will do, I just removed the other `herder::onRestart` and I forgot about the rest of the instances of `atLeastOnce()` (they are now all gone). Ill try and go through the tests on by one but understanding the domain specific anti-patterns (such as `herder::onRestart`) isn't immediately obvious on my end. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
