mdedetrich commented on PR #12728:
URL: https://github.com/apache/kafka/pull/12728#issuecomment-1801718171
@C0urante So I can confirm the following things
* No methods are directly called on mocks (I checked both mocks defined by
the `@Mock` annotation or local mocks created with `mock(...)`)
* There is no usage of `atLeastOnce()` and there is only one case of `times`
(i.e. `times(2)`)
* I think I found a couple of cases where `// herder.stop()` comments were
in incorrect places so I added a `Move herder.stop() comments to appropriate
place` comment
* I may have missed some cases regarding comments, I am slightly unsure
about the `// herder.stop()` comments because I don't know if the comment
refers to an actual call of `herder.stop()` or if `herder.stop()` is being
called behind the scenes (but this to me doesn't make sense anyways)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
