pprovenzano commented on code in PR #14369:
URL: https://github.com/apache/kafka/pull/14369#discussion_r1385385403
##########
core/src/main/scala/kafka/server/ReplicaManager.scala:
##########
@@ -2296,13 +2298,41 @@ class ReplicaManager(val config: KafkaConfig,
if (sendZkNotification)
if (zkClient.isEmpty) {
- warn("Unable to propagate log dir failure via Zookeeper in KRaft mode")
+ val uuid = logManager.directoryId(dir)
+ if (uuid.isDefined && lifecycleManager.isDefined)
+ lifecycleManager.get.propagateDirectoryFailure(uuid.get)
Review Comment:
When would we ever get into this state. If this can only occur during
migration, I thought we agreed that we would fail the broker if a directory
failed during migration.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
