soarez commented on code in PR #14369:
URL: https://github.com/apache/kafka/pull/14369#discussion_r1386810622
##########
core/src/main/scala/kafka/server/ReplicaManager.scala:
##########
@@ -2296,13 +2298,41 @@ class ReplicaManager(val config: KafkaConfig,
if (sendZkNotification)
if (zkClient.isEmpty) {
- warn("Unable to propagate log dir failure via Zookeeper in KRaft mode")
+ val uuid = logManager.directoryId(dir)
+ if (uuid.isDefined && lifecycleManager.isDefined)
+ lifecycleManager.get.propagateDirectoryFailure(uuid.get)
Review Comment:
Ah! I think that variable should get a new name. The "Zk" part of it conveys
that instead of an RPC to the controller, the notification goes via ZK, but
what the flag actually does is determine whether the controller should know
about the failure or not – regardless of what notification mechanism is used.
I'll update this PR to rename that variable.
##########
core/src/main/scala/kafka/server/ReplicaManager.scala:
##########
@@ -2296,13 +2298,41 @@ class ReplicaManager(val config: KafkaConfig,
if (sendZkNotification)
if (zkClient.isEmpty) {
- warn("Unable to propagate log dir failure via Zookeeper in KRaft mode")
+ val uuid = logManager.directoryId(dir)
+ if (uuid.isDefined && lifecycleManager.isDefined)
+ lifecycleManager.get.propagateDirectoryFailure(uuid.get)
Review Comment:
Ah! I think that variable should get a new name. The "Zk" part of it conveys
that instead of an RPC to the controller, the notification goes via ZK, but
what the flag actually does is determine whether the controller should know
about the failure or not – regardless of what notification mechanism is used.
I'll update this PR to rename that variable.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
