apoorvmittal10 commented on code in PR #14632:
URL: https://github.com/apache/kafka/pull/14632#discussion_r1387077385
##########
core/src/main/scala/kafka/server/DynamicConfig.scala:
##########
@@ -111,6 +112,16 @@ object DynamicConfig {
}
}
+ object ClientMetrics {
+ private val clientConfigs = kafka.metrics.ClientMetricsConfigs.configDef()
+
+ def configKeys: util.Map[String, ConfigDef.ConfigKey] =
clientConfigs.configKeys
+
+ def names: util.Set[String] = clientConfigs.names
+
+ def validate(props: Properties) = DynamicConfig.validate(clientConfigs,
props, customPropsAllowed = false)
Review Comment:
I might be wrong but isn't it required to list all ConfigCommandOptions i.e.
below line added in ConfigCommand.scala to list options for client-metrics.
```
"For entity-type '" + ConfigType.ClientMetrics + "': " +
DynamicConfig.ClientMetrics.names.asScala.toSeq.sorted.map("\t" +
_).mkString(nl, nl, nl) +
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
