junrao commented on code in PR #14632:
URL: https://github.com/apache/kafka/pull/14632#discussion_r1387265452
##########
core/src/main/scala/kafka/server/DynamicConfig.scala:
##########
@@ -111,6 +112,16 @@ object DynamicConfig {
}
}
+ object ClientMetrics {
+ private val clientConfigs = kafka.metrics.ClientMetricsConfigs.configDef()
+
+ def configKeys: util.Map[String, ConfigDef.ConfigKey] =
clientConfigs.configKeys
+
+ def names: util.Set[String] = clientConfigs.names
+
+ def validate(props: Properties) = DynamicConfig.validate(clientConfigs,
props, customPropsAllowed = false)
Review Comment:
The code you pasted only uses `ClientMetrics.names`. Are
`ClientMetrics.validate` and `ClientMetrics.configKeys` ever used?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
