agavra commented on code in PR #14708:
URL: https://github.com/apache/kafka/pull/14708#discussion_r1387215167
##########
streams/src/main/java/org/apache/kafka/streams/TopologyConfig.java:
##########
@@ -217,8 +217,19 @@ public TopologyConfig(final String topologyName, final
StreamsConfig globalAppCo
}
}
+ public static Materialized.StoreType parse(final String storeType) {
Review Comment:
🤦 I forgot this is public too, it doesn't need to be. Any suggestions of
where to put it?
##########
streams/src/main/java/org/apache/kafka/streams/TopologyConfig.java:
##########
@@ -217,8 +217,19 @@ public TopologyConfig(final String topologyName, final
StreamsConfig globalAppCo
}
}
+ public static Materialized.StoreType parse(final String storeType) {
Review Comment:
🤦 I forgot this is public too, it doesn't need to be. Any suggestions of
where to put it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
