ableegoldman commented on code in PR #14708:
URL: https://github.com/apache/kafka/pull/14708#discussion_r1388683082
##########
streams/src/main/java/org/apache/kafka/streams/TopologyConfig.java:
##########
@@ -217,8 +217,19 @@ public TopologyConfig(final String topologyName, final
StreamsConfig globalAppCo
}
}
+ public static Materialized.StoreType parse(final String storeType) {
Review Comment:
I hate that we moved this into a public package and made it a public API
(even though I'm sure I ok'ed it at the time) 😞
I don't really have time to do a KIP to move it back (or just delete it
outright) but we should really do that. Maybe we can file a newbie ticket and
someone will pick it up..
##########
streams/src/main/java/org/apache/kafka/streams/TopologyConfig.java:
##########
@@ -217,8 +217,19 @@ public TopologyConfig(final String topologyName, final
StreamsConfig globalAppCo
}
}
+ public static Materialized.StoreType parse(final String storeType) {
Review Comment:
I hate that we moved this into a public package and made it a public API
(even though I'm sure I ok'ed it at the time) 😞
I don't really have time to do a KIP to move it back (or just delete it
outright) but we should really do that. Maybe we can file a newbie ticket and
someone will pick it up..
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
