cmccabe commented on PR #14369:
URL: https://github.com/apache/kafka/pull/14369#issuecomment-1809239029
I don't have a good place to put this comment (github only lets me comment
on changed lines) but there is a problem with this code:
```
private class LogDirFailureHandler(name: String, haltBrokerOnDirFailure:
Boolean) extends ShutdownableThread(name) {
override def doWork(): Unit = {
val newOfflineLogDir = logDirFailureChannel.takeNextOfflineLogDir()
if (haltBrokerOnDirFailure) {
fatal(s"Halting broker because dir $newOfflineLogDir is offline")
Exit.halt(1)
}
handleLogDirFailure(newOfflineLogDir)
}
}
```
If the directory that failed is the metadata directory, we need to exit
unconditionally. This is because we have not implemented any way of failing
over to a different directory for metadata.
I suppose we should have a post-3.7 follow-up JIRA for this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
