eduwercamacaro commented on code in PR #14735:
URL: https://github.com/apache/kafka/pull/14735#discussion_r1391877914
##########
streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java:
##########
@@ -70,6 +71,7 @@
import static
org.apache.kafka.streams.internals.StreamsConfigUtils.ProcessingMode.EXACTLY_ONCE_V2;
import static
org.apache.kafka.streams.processor.internals.StateManagerUtil.parseTaskDirectoryName;
+@SuppressWarnings("ClassFanOutComplexity")
Review Comment:
Oh, I see. I was thinking that this might be an unnecessary complexity for
the `TaskManager` class, and instead we can pass standby callback to the
`ActiveTaskCreator`. But not sure if Standby callback API is compatible with
the terminology used in the `ActiveTaskCreator` class.
##########
streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java:
##########
@@ -70,6 +71,7 @@
import static
org.apache.kafka.streams.internals.StreamsConfigUtils.ProcessingMode.EXACTLY_ONCE_V2;
import static
org.apache.kafka.streams.processor.internals.StateManagerUtil.parseTaskDirectoryName;
+@SuppressWarnings("ClassFanOutComplexity")
Review Comment:
Oh, I see. I was thinking that this might be an unnecessary complexity for
the `TaskManager` class, and instead we can pass standby callback to the
`ActiveTaskCreator`. But not sure if Standby callback API is compatible with
the terminology used in the `ActiveTaskCreator` class.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
