satishd commented on code in PR #14727:
URL: https://github.com/apache/kafka/pull/14727#discussion_r1392178184


##########
core/src/main/java/kafka/log/remote/RemoteLogManager.java:
##########
@@ -133,6 +134,10 @@ public class RemoteLogManager implements Closeable {
 
     private static final Logger LOGGER = 
LoggerFactory.getLogger(RemoteLogManager.class);
     private static final String REMOTE_LOG_READER_THREAD_NAME_PREFIX = 
"remote-log-reader";
+    private static final Set<RemoteLogSegmentState> 
SEGMENT_DELETION_VALID_STATES = Collections.unmodifiableSet(EnumSet.of(

Review Comment:
   @jeqo Leader will upload the required segment with a new UUID by finding the 
offset that needs to be copied as mentioned 
[here](https://github.com/apache/kafka/blob/trunk/core/src/main/java/kafka/log/remote/RemoteLogManager.java#L618).
 It will not change the state of the failed copy of an earlier segment. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to