jeqo commented on code in PR #14727:
URL: https://github.com/apache/kafka/pull/14727#discussion_r1392253771
##########
core/src/main/java/kafka/log/remote/RemoteLogManager.java:
##########
@@ -133,6 +134,10 @@ public class RemoteLogManager implements Closeable {
private static final Logger LOGGER =
LoggerFactory.getLogger(RemoteLogManager.class);
private static final String REMOTE_LOG_READER_THREAD_NAME_PREFIX =
"remote-log-reader";
+ private static final Set<RemoteLogSegmentState>
SEGMENT_DELETION_VALID_STATES = Collections.unmodifiableSet(EnumSet.of(
Review Comment:
Aha! I can see a new segment id being generated
[here](https://github.com/apache/kafka/blob/6140a9d682ed9bce31e4e4cff656fdecd6272eec/core/src/main/java/kafka/log/remote/RemoteLogManager.java#L725).
Got it, so there may be segment that will stay on copy_started until
eventually deleted. Then, the way to assess if this is not an issue is to check
that another topic-id-partition-offset combination with a different segment id
has copy_finished, isn't it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
